Modify

Ticket #1547 (closed task: fixed)

Opened 4 years ago

Last modified 3 years ago

loggerd enhancements

Reported by: juruen@… Owned by: jacalvo@…
Milestone: 1.2.10-maint Component: logs
Severity: major Keywords:
Cc:

Description

3 things that loggerd needs to do well:

  • It needs to initialize eBox log, because some parts of the code can call EBox::{debug,info...} methods. This could be the origin of permission issues in /var/log/ebox/ebox.log
  • It needs to log the result of eval. Actually, we should use try/otherwise and log with otherwise. It is probably that we are missing an error in that eval.
  • We need to deal with the file descriptor in our select more carefully. That code has an obvious race condition. What happens if were waiting on a select syscall, on a fd that belongs to a file that is removed and recreated by logrotate?

Attachments

Change History

comment:1 Changed 4 years ago by juruen@…

And of course a lot of testing.

comment:2 Changed 4 years ago by juruen@…

  • Owner changed from juruen@… to jacalvo@…

comment:3 Changed 4 years ago by jacalvo@…

Only second and third points needed now.

comment:4 Changed 4 years ago by jacalvo@…

We can try run loggerd on some files and then delete or modify one of them to see what happens.

comment:5 Changed 3 years ago by jacalvo@…

  • Status changed from new to closed
  • Resolution set to fixed

(In [15413]) NN: merged loggerd improvements branch (closes #1547)

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.