Small bugs in eBox backup module

[ejhernandez@…]

I've just checking the functionality from eBox client with new backup section and I found the following bugs:

1. When I run configure, no check about Readonly availability is done. Therefore eBox does NOT work if Readonly perl package is NOT installed.
2. Delete icon in backup list is shown underneath remainder modules. 1. Making a restore when "cdrecord" is missing or an attempt to restore a full backup with configuration restore from the backup list gives the following result:

   [error] Attempt to reassign a readonly scalar at /usr/share/perl5/EBox/Backup/RootCommands.pm line 10
   Compilation failed in require at /usr/share/perl5/EBox/Backup/OpticalDiscDrives.pm line 12.
   BEGIN failed--compilation aborted at /usr/share/perl5/EBox/Backup/OpticalDiscDrives.pm line 12.
   Compilation failed in require at /usr/share/perl5/Apache/Reload.pm line 140.
   

3. An attempt to restore a full backup with both restore modes from a file gives the following result:

   INFO> Base.pm:165 EBox::CGI::Base::_checkForbiddenChars - Invalid characters in param value %2Fvar%2Flib%2Febox%2Ftmp%2Fbackupt55KrW.
   DEBUG> Base.pm:167 EBox::CGI::Base::_checkForbiddenChars - The input contains invalid characters. All alphanumeric characters, plus these non alphanumeric chars: /.?&+:-@ and spaces are allowed.
   

[ejhernandez@…]

I'm gonna try to solve them

[ejhernandez@…]

(In [5693]) Fixing first bug refs #254

[ejhernandez@…]

Fixed 1st bug in [5693].

[ejhernandez@…]

(In [5694]) Fixing help message typo and 2nd bug refs #254

[ejhernandez@…]

Fixed 2nd bug in [5694].

[ejhernandez@…]

Updating wiki formatting.

[anonymous]

THe first bug is invalid. Readonly must be checked in libebox not here. I will revert [5693] the next monday.

The second bug was originally fixed in css changing the width attribute; maybe is a better solution

The third has arose other times when installing Readonly and Readonly:XS. eBox needs to be restart after installing those two modules or it will be messing up thing due to mod-perl module persistence.

I will fix the fourth the next monday

-- Javier

[ejhernandez@…]

3rd is NOT possible to reproduce since it only happens when you're first install Readonly in an upgraded eBox version. Since Readonly is required in eBox restarting, error can be workaround with an eBox restarting as Javier said above.

[ejhernandez@…]

wikiformatting typo

[ejhernandez@…]

More information added from 4th bug

[javier.amor.garcia@…]

(In [5702]) fourth bug fixed .refs #254

[ejhernandez@…]

My spent time